Skip to content

deps: call OPENSSL_free after ANS1_STRING_to_UTF8 #60609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: call OPENSSL_free after ANS1_STRING_to_UTF8 #60609

wants to merge 1 commit into from
+4 −3

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Nov 6, 2025 •
edited
Loading

PTAL @mcollina @jasnell @smithc

Refs: #58380

I took the liberty to add you as Co-Authored-By - I hope you don't mind. Can you check if I'm using your best email?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2025

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@RafaelGSS RafaelGSS marked this pull request as ready for review November 6, 2025 20:23
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Nov 6, 2025
@RafaelGSS RafaelGSS added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS RafaelGSS force-pushed the fix-leak-ANS1_STRING_to_UTF8 branch from e06e579 to 615f5cd Compare November 6, 2025 20:30
smithc
smithc reviewed Nov 6, 2025
View reviewed changes
smithc
smithc reviewed Nov 6, 2025
View reviewed changes
mcollina
mcollina approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS @smithc
deps: call OPENSSL_free after ANS1_STRING_to_UTF8
60adee1 
Co-Authored-By: Chris Smith <[email protected]>
Signed-off-by: RafaelGSS <[email protected]>
@RafaelGSS RafaelGSS force-pushed the fix-leak-ANS1_STRING_to_UTF8 branch from 64ce4c4 to 60adee1 Compare November 7, 2025 13:36
@RafaelGSS RafaelGSS mentioned this pull request Nov 7, 2025
Closed
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70086/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70087/

@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

+1 more reviewer

@smithc smithc smithc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@RafaelGSS @nodejs-github-bot @mcollina @jasnell @smithc @lpinca @juanarbol @marco-ippolito @aduh95